Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows - Backslashes is the escape #23177

Closed
wants to merge 1 commit into from

Conversation

misaku
Copy link
Contributor

@misaku misaku commented Jan 27, 2019

Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle
issue:23176
i found this fix in past commit (0.57) and i submit again.

Changelog:

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Test Plan:

in windows run react-native link and start error, Backslashes is the escape character and will result in an invalid path in settings.gradle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

@pull-bot
Copy link

Warnings
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS

@cpojer
Copy link
Contributor

cpojer commented Jan 28, 2019

Thanks for sending this Pull Request. We actually removed the local-cli folder from this repository. It is now part of react-native-cli here: https://github.com/react-native-community/react-native-cli

Please submit your Pull Request there and it will make it into the latest version of React Native.

@cpojer cpojer closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants