-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nightly support for prebuilds #49991
Open
cipolleschi
wants to merge
7
commits into
facebook:main
Choose a base branch
from
cipolleschi:export-D71050926
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e folly flags (facebook#49969) Summary: Pull Request resolved: facebook#49969 Improved RCT-Folly podspec by configuring it as a prepare step, so that we don't need to forward the folly flags to all the others pods and to 3rd party dependencies. ## Changelog: [INTERNAL] - Configure folly in a prepare step Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032640 Reviewed By: javache Pulled By: javache
…ok#49812) Summary: There are two environment variables that is related to ReactNativeDependencies: - `RCT_USE_DEP_PREBUILD `: If set to 1, ReactNativeDependencies will be built from source. - `RCT_DEPS_VERSION`: If set to 1, it will override the version of ReactNativeDependencies to be used. bypass-github-export-checks ## Changelog: [INTERNAL] - Introduced functions to configure ReactNativeDependencies in Cocoapods Pull Request resolved: facebook#49812 Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D70968672 Reviewed By: javache Pulled By: javache
…cies.podspec (facebook#49971) Summary: Pull Request resolved: facebook#49971 Updated the Cocoapods infrastructure to use the new the `ReactNativeDependencies.podspec` ## Changelog: [INTERNAL] - Configured the Cocoapods infra to use the new `ReactNativeDependencies.podspec` Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032638 Reviewed By: javache Pulled By: javache
…ce (facebook#49968) Summary: Pull Request resolved: facebook#49968 Updates all the core podspec to use the new `ReactNativeDependencies` podspec ## Changelog: [INTERNAL] - Updates Modules in core to use the new dependencies. Test Plan: ✅ Run Rn-Tester and verify that it works as expected both building deps from source and using prebuilt tarballs ✅ Add third-party library (react-native-reanimated) and perform the same tests to verify that it works with the changed podspec and utilities Differential Revision: D71032639
) Summary: Pull Request resolved: facebook#49970 This change add supports to pass a tarball from a local file to the ReactNativeDependencies podspec, so that we can build React Native using a local copy or the RNDependencies and we can use it also in CI. ## Changelog: [INTERNAL] - Add support for local tarballs Differential Revision: D71032641
Summary: Pull Request resolved: facebook#49978 This change connects the RNDependencies we prebuild in CI with the other iOS jobs we have. By doing so, we aim to speed up the build time in CI, saving time and money. ## Changelog: [Internal] - Connect the ReactNativeDependencies in CI Differential Revision: D71034587
Summary: This change adds nightly support for prebuilds. t works the same way hermes works: if the react native version contains nightly, we try to use that version to download the right tarball. To work, it needs to use the `RCT_USE_RN_DEP` env variable. ## Changelog [Internal] - Add Nightly support to consume ReactNativeDependencies Reviewed By: cortinico Differential Revision: D71050926
This pull request was exported from Phabricator. Differential Revision: D71050926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds nightly support for prebuilds.
t works the same way hermes works: if the react native version contains nightly, we try to use that version to download the right tarball.
To work, it needs to use the
RCT_USE_RN_DEP
env variable.Changelog
[Internal] - Add Nightly support to consume ReactNativeDependencies
Reviewed By: cortinico
Differential Revision: D71050926