Allow listeners in EventEmitter #49998
Open
+83
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated. This change moves the `asDynamic` method from `ScrollEvent` to the base `EventPayload` interface, defaulting the implemention to returning a null value. ## Changelog [Internal] Reviewed By: zeyap Differential Revision: D71046682
Summary: We have listeners for EventDispatcher, but we don't have any listener capabilities for synchronous hooks from events on the UI thread. This proposal adds an affordance for generic event listeners that can be attached by the host platform mounting manager, e.g., to wire events to NativeAnimated event drivers. ## Changelog [Internal] Differential Revision: D71050838
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71050838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have listeners for EventDispatcher, but we don't have any listener capabilities for synchronous hooks from events on the UI thread.
This proposal adds an affordance for generic event listeners that can be attached by the host platform mounting manager, e.g., to wire events to NativeAnimated event drivers.
Changelog
[Internal]
Differential Revision: D71050838