Allow value extraction from folly::dynamic events #50032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
62e4e5f to
06c284f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
06c284f to
2a640d8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
2 times, most recently
from
006211c to
a9ede26
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
a9ede26 to
45e1bca
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
45e1bca to
59cef2a
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
59cef2a to
b385cc8
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 14, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
0faee93 to
7da5f44
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
7da5f44 to
0197deb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 17, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
0197deb to
37f20a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
Summary: Pull Request resolved: facebook#49988 NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. In practice, NativeAnimated just needs to be able to extract an numeric value from a path to drive an animation. Rather than converting events to dynamic, or otherwise special casing event handling, this change allows arbitrary payloads to implement `EventPayload::extractValue` to retrieve JS property path values directly from events, without intermediate conversions to dynamic. ## Changelog [Internal] Differential Revision: D71046682
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
rozele
force-pushed
the
export-D71198197
branch
from
37f20a1 to
7bebe17
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
…#50032) Summary: In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Reviewed By: javache Differential Revision: D71198197
|
This pull request was exported from Phabricator. Differential Revision: D71198197 |
rozele
force-pushed
the
export-D71198197
branch
from
7bebe17 to
b4baf09
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 18, 2025
Summary: Pull Request resolved: facebook#50032 In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads. Events disptached with folly::dynamic payloads have alignment with the `EventPayload::extractValue` method, added for integration with other capabilities like native animations. When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers. ## Changelog [Internal] Differential Revision: D71198197
|
This pull request has been merged in 9d7cdfe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the new architecture, Android dispatches all events with folly::dynamic payloads. Various other callsites in some host platforms similarly dispatch events with folly::dynamic payloads.
Events disptached with folly::dynamic payloads have alignment with the
EventPayload::extractValuemethod, added for integration with other capabilities like native animations.When combined with a general pupose synchronous listener on facebook::react::EventEmitter, this should allow easier integration with host platform native event animation drivers.
Changelog
[Internal]
Differential Revision: D71198197