Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure for passive/non-passive event support for future API exploration #15036

Merged
merged 20 commits into from
Mar 15, 2019
+240 −101
Merged

Add infrastructure for passive/non-passive event support for future API exploration #15036

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
858608b
Add infrastructure for passive/non-passive event support for future e…
trueadm Mar 6, 2019
0ae3ba3
More Flow fixes
trueadm Mar 6, 2019
3bd6176
Add fallback to Map if there is no WeakMap
trueadm Mar 6, 2019
06f2c3b
Fix prettier
trueadm Mar 6, 2019
bbae02d
Update comment
trueadm Mar 6, 2019
68934d8
Add isLegacy flag to EventPlugins
trueadm Mar 13, 2019
37224ea
Handle fallback for no passive support
trueadm Mar 13, 2019
c683859
Fixed typo + improve code size
trueadm Mar 13, 2019
e7e742f
Changed to enum for passive event types and addressed PR feedback
trueadm Mar 13, 2019
ccf3884
Added comment to describe intent
trueadm Mar 13, 2019
c9fc178
use canUseDOM
trueadm Mar 13, 2019
5d5b972
Cleaned up some logic and reduces more bytes
trueadm Mar 13, 2019
e186b09
Fix typo
trueadm Mar 14, 2019
1dff1fc
Address nits
trueadm Mar 14, 2019
8f79ee8
Addressed feedback and took a different approach with flags
trueadm Mar 14, 2019
159280c
Merge branch 'master' into passive-event-listening
trueadm Mar 14, 2019
2acacf8
Wrap function in flags
trueadm Mar 14, 2019
3b67255
Remove more code that is not needed anymore
trueadm Mar 14, 2019
5b044cf
Adds flag to another location
trueadm Mar 14, 2019
8b34efa
Address feedback on addEventListener
trueadm Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove more code that is not needed anymore
@trueadm
trueadm committed Mar 14, 2019
commit 3b6725584867d84e7b98a6289414e2e08fd9d717
8 changes: 4 additions & 4 deletions packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js
View file
Original file line number Diff line number Diff line change
@@ -331,15 +331,15 @@ describe('ReactBrowserEventEmitter', () => {

it('should listen to events only once', () => {
spyOnDevAndProd(EventTarget.prototype, 'addEventListener');
ReactBrowserEventEmitter.listenTo(ON_CLICK_KEY, document, true);
ReactBrowserEventEmitter.listenTo(ON_CLICK_KEY, document, true);
ReactBrowserEventEmitter.listenTo(ON_CLICK_KEY, document);
ReactBrowserEventEmitter.listenTo(ON_CLICK_KEY, document);
expect(EventTarget.prototype.addEventListener).toHaveBeenCalledTimes(1);
});

it('should work with event plugins without dependencies', () => {
spyOnDevAndProd(EventTarget.prototype, 'addEventListener');

ReactBrowserEventEmitter.listenTo(ON_CLICK_KEY, document, true);
ReactBrowserEventEmitter.listenTo(ON_CLICK_KEY, document);

expect(EventTarget.prototype.addEventListener.calls.argsFor(0)[0]).toBe(
'click',
@@ -349,7 +349,7 @@ describe('ReactBrowserEventEmitter', () => {
it('should work with event plugins with dependencies', () => {
spyOnDevAndProd(EventTarget.prototype, 'addEventListener');

ReactBrowserEventEmitter.listenTo(ON_CHANGE_KEY, document, true);
ReactBrowserEventEmitter.listenTo(ON_CHANGE_KEY, document);

const setEventListeners = [];
const listenCalls = EventTarget.prototype.addEventListener.calls.allArgs();