-
Notifications
You must be signed in to change notification settings - Fork 48k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note about renderComponent()
requirement
#1799
Conversation
This isn't true, but it replaces the contents of the node, which may be valuable to state. |
Someone mentioned this to me on IRC, thought it would be valuable for the docs. Feel free to close this if invalid, otherwise I'm happy to reword it. |
What @spicyj said. Let's reword it to be truthful. Also, let's use our other formatting we have for other notes (see it in action - http://facebook.github.io/react/docs/top-level-api.html#react.unmountcomponentatnode) |
Reworded and adapted the formatting. |
> Note: | ||
> | ||
> `React.renderComponent()` currently replaces the contents of the node, | ||
> which might be valuable to state. This restriction will go away in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better, thanks! Just a couple small things.
Let's drop the "which might be valuable to state".
And then "will go away" -> "may go away" (I'm hopeful but don't want to make promises we can't keep)
Updated. |
@zpao My comment on IRC was with regards to react-future |
Yup, we plan to have a toElement: #1711. |
Added note about `renderComponent()` requirement
Thanks! |
No description provided.