Skip to content
This repository was archived by the owner on Jan 10, 2020. It is now read-only.

Export KFVectorView and the types for accessible Data Model objects #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

skagedal
Copy link

@skagedal skagedal commented Jan 1, 2017

Issue #87.

@renyu-io
Copy link
Contributor

Hi @skagedal
I agree to expose KFVectorView, but why other data models?
Is the implementation detail necessary for users?

@skagedal
Copy link
Author

Hi!

I think it is a bit strange API design that the way to setup a KFVectorLayer is to assign a KFVector to it, and then the KFVector type is not exposed. KFVectorFromFromDictionary "feels" more like a helper function. Maybe it would be more sense as an opaque type if there was a [KFVector initWithDictionary:]...?

I think that it might be useful to be able to access the model. There might be some aspect of the animation that you want to control programmatically. That's what I was trying to do anyway. But as I kept playing around, I realized that the model wasn't quite designed for that and is at the moment probably better kept as an implementation detail. :)

Regards, Simon

@renyu-io
Copy link
Contributor

Hi @skagedal,

I agree with you control model programmatically could be very interesting, but currently these models does not have very friendly API.
And KFVector is exposed, I like [KFVector initWithDictionary:] a lot, feel free to make these changes.
But at this moment, I don't think we should expose all models. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants