Hard-code Joblib backend to loky #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
omry
reviewed
Feb 18, 2020
plugins/hydra_joblib_launcher/hydra_plugins/hydra_joblib_launcher/joblib_launcher.py
Outdated
Show resolved
Hide resolved
plugins/hydra_joblib_launcher/hydra_plugins/hydra_joblib_launcher/joblib_launcher.py
Outdated
Show resolved
Hide resolved
tomMoral
reviewed
Feb 18, 2020
plugins/hydra_joblib_launcher/hydra_plugins/hydra_joblib_launcher/joblib_launcher.py
Show resolved
Hide resolved
|
oh dang, it fails CI. I didn't notice that CI did not run on this PR. In the future, please at least run nox locally if CI is not running on your PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Launching jobs using thread-based parallelism is incompatible with Hydra. This PR updates the Joblib Launcher plugin to hard-code the backend to process-based parallelism using Joblib's loky backend.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run multiple tests on CircleCI in order to cover sporadically occurring failures
Related Issues and PRs
#421