-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(falco): use header file for json schema #3325
cleanup(falco): use header file for json schema #3325
Conversation
Signed-off-by: Luca Guerra <[email protected]>
cfb73bc
to
db4f70e
Compare
/milestone 0.39.0 |
Signed-off-by: Luca Guerra <[email protected]>
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 643a46920fdc0d11fba2549be8a082490ba75fc4
|
/unhold |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
I have been modifying the json schema several time in the last few days and every time I wasted some time with the minified and large file. I'd rather have this file inside an header so it's easier to modify. It looks like MSVC is not complaining about this one but there is a workaround in case it does.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: