Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(falco): use header file for json schema #3325

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Sep 13, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

I have been modifying the json schema several time in the last few days and every time I wasted some time with the minified and large file. I'd rather have this file inside an header so it's easier to modify. It looks like MSVC is not complaining about this one but there is a workaround in case it does.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@LucaGuerra LucaGuerra force-pushed the update/saner-json-schema branch from cfb73bc to db4f70e Compare September 13, 2024 14:50
@LucaGuerra LucaGuerra changed the title wip: testing: saner json_schema file cleanup(falco): use header file for json schema Sep 13, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Sep 13, 2024

/milestone 0.39.0
Thanks!!

@poiana poiana added this to the 0.39.0 milestone Sep 13, 2024
Copy link

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 13, 2024

LGTM label has been added.

Git tree hash: 643a46920fdc0d11fba2549be8a082490ba75fc4

@FedeDP
Copy link
Contributor

FedeDP commented Sep 16, 2024

/unhold

@poiana poiana merged commit 037d7f9 into falcosecurity:master Sep 16, 2024
35 of 36 checks passed
@LucaGuerra LucaGuerra deleted the update/saner-json-schema branch September 16, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants