Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): add brotli to the Falco image #3399

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

Fixes the image falcosecurity/falco:master which is currently experimenting technical difficulties:

/usr/bin/falco: error while loading shared libraries: libbrotlienc.so.1: cannot open shared object file: No such file or directory
/ # ldd /usr/bin/falco
        linux-vdso.so.1 (0x00007ffc3f1f9000)
        libelf.so.1 => /usr/lib/libelf.so.1 (0x00007e2b45b03000)
        libbrotlicommon.so.1 => /usr/lib/libbrotlicommon.so.1 (0x00007e2b45ae0000)
        libbrotlienc.so.1 => not found
        libbrotlidec.so.1 => /usr/lib/libbrotlidec.so.1 (0x00007e2b45ad3000)
        libm.so.6 => /lib/libm.so.6 (0x00007e2b459f1000)
        libpthread.so.0 => /lib/libpthread.so.0 (0x00007e2b459ea000)
        libc.so.6 => /lib/libc.so.6 (0x00007e2b457f5000)
        libdl.so.2 => /lib/libdl.so.2 (0x00007e2b457f0000)
        librt.so.1 => /lib/librt.so.1 (0x00007e2b457eb000)
        /lib64/ld-linux-x86-64.so.2 (0x00007e2b45b25000)
        libz.so.1 => /lib/libz.so.1 (0x00007e2b457d1000)
        libzstd.so.1 => /usr/lib/libzstd.so.1 (0x00007e2b4572f000)

Actually I think libbrotli shouldn't even be there. I will investigate further but this fixes it for the time being.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(docker): add brotli to the Falco image

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 6, 2024

LGTM label has been added.

Git tree hash: 07db26f61e4ad1317ae1d118822457ea6f667c3c

@FedeDP
Copy link
Contributor

FedeDP commented Nov 6, 2024

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Nov 6, 2024
@poiana poiana merged commit edf36c0 into falcosecurity:master Nov 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants