Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: chore(ci): use driverkit latest docker image in latest-kernel workflow. #2306

Closed
wants to merge 1 commit into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 12, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Avoids Error: no downloadable artifacts found (expired) errors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 12, 2025

JavaScript Actions in Alpine containers are only supported on x64 Linux runners. Detected Linux Arm64

I forgot about this one :/
/close

@poiana poiana closed this Mar 12, 2025
@poiana
Copy link
Contributor

poiana commented Mar 12, 2025

@FedeDP: Closed this PR.

In response to this:

JavaScript Actions in Alpine containers are only supported on x64 Linux runners. Detected Linux Arm64

I forgot about this one :/
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP FedeDP added this to the TBD milestone Mar 12, 2025
Copy link

Perf diff from master - unit tests

     8.92%     +0.89%  [.] sinsp_thread_manager::create_thread_dependencies
     9.14%     -0.84%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     3.26%     -0.29%  [.] gzfile_read
     5.36%     +0.27%  [.] sinsp_evt::get_type
    18.76%     +0.27%  [.] sinsp_threadinfo::get_main_thread
     5.75%     -0.26%  [.] sinsp_parser::reset
     0.74%     -0.23%  [.] libsinsp::events::is_unknown_event
     0.48%     +0.17%  [.] sinsp_evt::get_direction
     1.07%     -0.17%  [.] scap_event_decode_params
     7.05%     +0.17%  [.] sinsp::next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0213         +0.0212           146           149           146           149
BM_sinsp_split_median                                          +0.0258         +0.0257           145           149           145           149
BM_sinsp_split_stddev                                          -0.1864         -0.1865             2             1             2             1
BM_sinsp_split_cv                                              -0.2034         -0.2034             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0899         -0.0900            59            54            59            54
BM_sinsp_concatenate_paths_relative_path_median                -0.0881         -0.0882            59            54            59            54
BM_sinsp_concatenate_paths_relative_path_stddev                +0.5278         +0.5260             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.6787         +0.6769             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0356         +0.0355            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0355         +0.0354            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.8792         +0.8714             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.8146         +0.8072             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1119         -0.1119            58            51            58            51
BM_sinsp_concatenate_paths_absolute_path_median                -0.1126         -0.1127            57            51            57            51
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.2022         +0.2023             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.3536         +0.3538             0             0             0             0

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (d761f18) to head (301fa74).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2306   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         224      224           
  Lines       30133    30133           
  Branches     4605     4605           
=======================================
  Hits        23256    23256           
  Misses       6877     6877           
Flag Coverage Δ
libsinsp 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants