Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): download assets from latest driverkit release instead of release workflow #2307

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 12, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Avoids Error: no downloadable artifacts found (expired) errors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Perf diff from master - unit tests

     7.06%     -0.98%  [.] sinsp::next
     1.69%     +0.38%  [.] sinsp_thread_manager::get_thread_ref
    18.80%     +0.31%  [.] sinsp_threadinfo::get_main_thread
     1.74%     +0.31%  [.] sinsp_thread_manager::find_thread
     8.94%     +0.28%  [.] sinsp_thread_manager::create_thread_dependencies
     5.76%     +0.27%  [.] sinsp_parser::reset
     0.57%     +0.20%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     3.26%     -0.19%  [.] gzfile_read
     1.55%     -0.18%  [.] next
     0.74%     -0.16%  [.] sinsp_evt::get_ts

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0219         +0.0219           146           149           146           149
BM_sinsp_split_median                                          +0.0271         +0.0271           145           149           145           149
BM_sinsp_split_stddev                                          +0.1697         +0.1696             2             2             2             2
BM_sinsp_split_cv                                              +0.1446         +0.1445             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0545         +0.0544            59            62            59            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0578         +0.0577            59            62            59            62
BM_sinsp_concatenate_paths_relative_path_stddev                +1.7689         +1.7673             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.6259         +1.6244             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0472         +0.0472            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0475         +0.0475            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.4011         +0.3970             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.3380         +0.3340             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1170         +0.1170            58            64            58            64
BM_sinsp_concatenate_paths_absolute_path_median                +0.0985         +0.0985            57            63            57            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +4.8117         +4.8094             0             2             0             2
BM_sinsp_concatenate_paths_absolute_path_cv                    +4.2030         +4.2010             0             0             0             0

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (d761f18) to head (bf9bd6a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2307   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         224      224           
  Lines       30133    30133           
  Branches     4605     4605           
=======================================
  Hits        23256    23256           
  Misses       6877     6877           
Flag Coverage Δ
libsinsp 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 12, 2025

@poiana poiana added this to the 0.21.0 milestone Mar 12, 2025
@FedeDP FedeDP changed the title wip: chore(ci): download assets from latest driverkit release instead of release workflow chore(ci): download assets from latest driverkit release instead of release workflow Mar 12, 2025
@poiana poiana merged commit 9ef8acd into master Mar 12, 2025
53 of 59 checks passed
@poiana poiana deleted the chore/download_release_asset_latest_kernel branch March 12, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants