-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single compose file #214
Single compose file #214
Conversation
Currently being tested by a windows user. |
Tested on
|
@ypc-faros could you check if I got the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Let's put comments around the section from the original Airbyte compose file so it would be easier for us to merge with upstream later on.
Already done |
Looks good 👍 |
Description
On windows, one sees local volume related errors (see #173 and this slack thread). However, we noticed that:
docker-compose -f airbyte-services.yaml up
did not have any volume issues (i.e. airbyte-server got successfully created.Hence, there may be some issues with the
extends
keyword, which is not surprising given its checkered history (here, and here).The fix is to group everything into a single compose file.
Fixes #173
Type of change
Checklist
(Delete what does not apply)