-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for version comment in request payload #103
Add support for version comment in request payload #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one minor comment about documenting the field, but otherwise LGTM
headers: | ||
Accept-Ranges: | ||
- bytes | ||
- bytes | ||
- bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a bug in the VCR recorder, but this is leaking. No action required on your part, more of a mental note for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bug. I have checked my latest PRs and they all have the same issue with Accept-Ranges
in the recordings.
@@ -84,10 +84,11 @@ func (c *Client) LatestVersion(i *LatestVersionInput) (*Version, error) { | |||
type CreateVersionInput struct { | |||
// Service is the ID of the service (required). | |||
Service string | |||
|
|||
Comment string `form:"comment,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please comment this (irony recognized) using Go's comment string so it's rendered in the client library docs on godoc.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I'll also add a comment to the Comment
field of the UpdateVersionInput
struct.
Add comment field to CreateVersionInput struct and attach payload to CreateVersion request. fix #102
This solves #102.