Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseTLS field for Splunk logging #309

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Oct 4, 2021

and I'll be adding support in our TF provider as well once a new version is released:
https://registry.terraform.io/providers/fastly/fastly/latest/docs/resources/service_v1#nested-schema-for-splunk

main diff: 3bbbf37

@smaeda-ks
Copy link
Contributor Author

We probably should update:

// ProjectVersion is the version of this library.
var ProjectVersion = "4.0.0"

@Integralist
Copy link
Collaborator

@smaeda-ks doh! yes we should update that to 5.0.0.

Can you do that in this PR please. Thanks.

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the ProjectVersion field could also be bumped (appreciate it's not related but might as well just get that change merged ASAP).

@smaeda-ks
Copy link
Contributor Author

@Integralist Thank you. Added a commit to bump the ProjectVersion

@Integralist Integralist merged commit fdf7d7c into fastly:main Oct 5, 2021
@Integralist Integralist added the enhancement New feature or request label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants