Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used resetFieldState to fix insert and unshift bugs #34

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented Jul 15, 2019

Fixes #21, and a few other bugs.

Requires [email protected].

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     11    +1     
  Lines         145    147    +2     
  Branches       29     29           
=====================================
+ Hits          145    147    +2
Impacted Files Coverage Δ
src/move.js 100% <ø> (ø) ⬆️
src/removeBatch.js 100% <100%> (ø) ⬆️
src/insert.js 100% <100%> (ø) ⬆️
src/remove.js 100% <100%> (ø) ⬆️
src/shift.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3effa4d...98123de. Read the comment docs.

@erikras erikras merged commit 60f3a99 into master Jul 15, 2019
@erikras erikras deleted the fix-insert-bugs branch July 15, 2019 16:46
@erikras
Copy link
Member Author

erikras commented Jul 15, 2019

Published in v3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong fields state after pop and unshift
1 participant