Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden mutator type to any #40

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

danielnixon
Copy link
Contributor

This will allow arrayMutators to be passed to a strongly typed mutators prop (which is coming in final-form/final-form#275 ) without causing a TypeScript compiler error.

This will allow `arrayMutators` to be passed to a strongly typed `mutators` prop (which is coming in final-form/final-form#275 ) without causing a TypeScript compiler error.
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         139    139           
  Branches       29     29           
=====================================
  Hits          139    139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b37726...c7ff329. Read the comment docs.

@erikras erikras merged commit 39a7a3f into final-form:master Oct 28, 2019
@DZapdos
Copy link

DZapdos commented Nov 20, 2019

Any update on when this will be released now that the changes to final-form have been released?

@erikras
Copy link
Member

erikras commented Nov 20, 2019

Published in v3.0.2.

@dartess
Copy link

dartess commented Jan 21, 2020

Maybe I don't understand something.
Still can't use arraiMutators in TS.

How can i fix this?
"final-form": "4.18.6",
"final-form-arrays": "3.0.2",

@danielnixon
Copy link
Contributor Author

danielnixon commented Jan 21, 2020

What if you follow the usage instructions example?

mutators: { ...arrayMutators },

@dartess
Copy link

dartess commented Jan 21, 2020

@danielnixon sorry, yes, it works, although it looks a little strange 😅! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants