Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flow libdefs file naming #52

Merged
merged 1 commit into from
May 14, 2020
Merged

fix: flow libdefs file naming #52

merged 1 commit into from
May 14, 2020

Conversation

maxmalov
Copy link
Contributor

@maxmalov maxmalov commented Apr 28, 2020

Currently, Flow is unable to pick bundled library definitions, since it can't match index.js.flow with final-form-arrays.cjs.js or final-form-arrays.es.js. So I borrowed build configuration from final-form repo https://github.com/final-form/final-form/blob/master/package-scripts.js#L58-L64 to resolve the issue

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          159       159           
  Branches        34        34           
=========================================
  Hits           159       159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bff53...5394b64. Read the comment docs.

@maxmalov maxmalov changed the title fix: flow libdefs naming fix: flow libdefs file naming May 12, 2020
@erikras erikras merged commit 7e27b5c into final-form:master May 14, 2020
@maxmalov maxmalov deleted the fix-flow-libdefs-build branch May 14, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants