Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Export Filter type from Firestore #2167

Closed
wants to merge 3 commits into from

Conversation

danReynolds
Copy link
Contributor

@danReynolds danReynolds commented Apr 27, 2023

Filter from Firestore isn't exposed on the exports. It'd be helpful to add I think so that folks can use it directly from this package.

Resolves: #2191

@google-cla
Copy link

google-cla bot commented Apr 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba lahirumaramba self-requested a review May 23, 2023 19:10
@lahirumaramba lahirumaramba self-assigned this May 23, 2023
@lahirumaramba lahirumaramba changed the title Add Firestore Filter export fix(firestore): Export Filter type from Firestore May 23, 2023
@lahirumaramba
Copy link
Member

Thank you @danReynolds for the contribution!
We need to update the api docs. Please do npm run api-extractor:local and push the new changes.

Please also update the unit and integration tests. For example:

expect(typeof admin.firestore.GeoPoint).to.be.not.undefined;

@jhuleatt
Copy link
Contributor

I added a test and ran API extractor in #2192, so I think we can use that one instead. I set @danReynolds as co-author

@jhuleatt
Copy link
Contributor

#2192 has been merged! Thanks for starting this work, @danReynolds!

@jhuleatt jhuleatt closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter export missing from Firestore package
3 participants