Add dependency vendoring support. #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (8dc0c0d3) is created by Prow via merging commits: 8c187fd 30db30b. |
|
/run binary-size |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (8dc0c0d3) is created by Prow via merging commits: 8c187fd 30db30b. |
The `VendorPlugin`(applied with `id 'firebase-vendor'`) adds a dedicated
`vendor` gradle configuration to the project, which can be used to
include the dependencies in the output library. Such dependencies are
are shaded under the library's package name to avoid symbol collisions.
Example use:
```kotlin
plugins {
id("com.android.library")
id("firebase-vendor")
}
android {
// ...
}
dependencies {
implementation("com.example:somelib:1.0")
// this will make this library available at compile time as well as
// will vendor it inside the produced aar under `com.mylib.com.example`.
vendor("com.example:libtovendor:1.0") {
// IMPORTANT: it the library (transitively) depends on any library
that contains `javax` or `java` packages, it must be excluded here
and added as a pom dependency below.
exclude("javax.inject", "javax.inject")
}
implementation("javax.inject:javax.inject:1")
}
```
|
/retest |
1 similar comment
|
/retest |
rlazo
approved these changes
Aug 18, 2020
buildSrc/src/main/java/com/google/firebase/gradle/plugins/VendorPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/VendorPlugin.kt
Outdated
Show resolved
Hide resolved
|
@vkryachko: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rlazo
approved these changes
Aug 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VendorPlugin(applied withid 'firebase-vendor') adds a dedicatedvendorgradle configuration to the project, which can be used toinclude the dependencies in the output library. Such dependencies are
are shaded under the library's package name to avoid symbol collisions.
Example use:
plugins { id("com.android.library") id("firebase-vendor") } android { // ... } dependencies { implementation("com.example:somelib:1.0") // this will make this library available at compile time as well as // will vendor it inside the produced aar under `com.mylib.com.example`. vendor("com.example:libtovendor:1.0") { // IMPORTANT: if the library (transitively) depends on any library // that contains `javax` or `java` packages, it must be excluded here // and added as a pom dependency below. exclude("javax.inject", "javax.inject") } implementation("javax.inject:javax.inject:1") }