Used Trust Types When API is available for gtag URL creation #7052

dwyfrequency · 2023-02-22T01:41:13Z

Fixes #7048 trusted types violation in analytics/src/helpers.ts

Research for changes:

changeset-bot · 2023-02-22T01:41:16Z

🦋 Changeset detected

Latest commit: 62f0a42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@firebase/firestore	Minor
firebase	Minor
@firebase/auth	Patch
@firebase/analytics	Patch
@firebase/firestore-compat	Patch
@firebase/auth-compat	Patch
@firebase/analytics-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-02-22T17:12:08Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (a2505bd) Merge (4e07017) Diff
browser 20.1 kB 20.9 kB +782 B (+3.9%)
esm5 24.8 kB 25.6 kB +778 B (+3.1%)
main 26.1 kB 26.9 kB +778 B (+3.0%)
module 20.1 kB 20.9 kB +782 B (+3.9%)

`@firebase/auth`

Type	Base (`a2505bd`)	Merge (`4e07017`)	Diff
browser	157 kB	157 kB	+8 B (+0.0%)
cordova	184 kB	184 kB	+8 B (+0.0%)
esm5	205 kB	205 kB	+8 B (+0.0%)
main	148 kB	148 kB	+8 B (+0.0%)
module	157 kB	157 kB	+8 B (+0.0%)
react-native	168 kB	168 kB	+8 B (+0.0%)

@firebase/auth/cordova
Type Base (a2505bd) Merge (4e07017) Diff
browser 184 kB 184 kB +8 B (+0.0%)
module 184 kB 184 kB +8 B (+0.0%)
@firebase/auth/internal
Type Base (a2505bd) Merge (4e07017) Diff
browser 167 kB 167 kB +8 B (+0.0%)
esm5 218 kB 218 kB +8 B (+0.0%)
main 184 kB 184 kB +8 B (+0.0%)
module 167 kB 167 kB +8 B (+0.0%)
@firebase/auth/react-native
Type Base (a2505bd) Merge (4e07017) Diff
browser 168 kB 168 kB +8 B (+0.0%)
module 168 kB 168 kB +8 B (+0.0%)

`@firebase/firestore`

Type	Base (`a2505bd`)	Merge (`4e07017`)	Diff
browser	274 kB	278 kB	+3.81 kB (+1.4%)
esm5	341 kB	346 kB	+4.32 kB (+1.3%)
main	549 kB	553 kB	+4.16 kB (+0.8%)
module	274 kB	278 kB	+3.81 kB (+1.4%)
react-native	274 kB	278 kB	+3.78 kB (+1.4%)

`@firebase/firestore-lite`

Type	Base (`a2505bd`)	Merge (`4e07017`)	Diff
browser	87.4 kB	87.5 kB	+106 B (+0.1%)
esm5	105 kB	105 kB	+108 B (+0.1%)
main	149 kB	149 kB	-242 B (-0.2%)
module	87.4 kB	87.5 kB	+106 B (+0.1%)
react-native	87.6 kB	87.7 kB	+73 B (+0.1%)

`bundle`

19 size changes

Type	Base (`a2505bd`)	Merge (`4e07017`)	Diff
analytics (logEvent)	43.1 kB	43.5 kB	+433 B (+1.0%)
auth (Anonymous)	67.6 kB	67.6 kB	+8 B (+0.0%)
auth (EmailAndPassword)	71.7 kB	71.7 kB	+8 B (+0.0%)
auth (GoogleFBTwitterGitHubPopup)	94.0 kB	94.0 kB	+8 B (+0.0%)
auth (GooglePopup)	91.3 kB	91.3 kB	+8 B (+0.0%)
auth (GoogleRedirect)	91.5 kB	91.5 kB	+8 B (+0.0%)
auth (Phone)	77.7 kB	77.7 kB	+8 B (+0.0%)
firestore (Persistence)	282 kB	283 kB	+1.55 kB (+0.6%)
firestore (Query Cursors)	220 kB	221 kB	+1.34 kB (+0.6%)
firestore (Query)	218 kB	219 kB	+1.34 kB (+0.6%)
firestore (Read data once)	205 kB	206 kB	+1.27 kB (+0.6%)
firestore (Realtime updates)	207 kB	209 kB	+1.27 kB (+0.6%)
firestore (Transaction)	189 kB	190 kB	+1.30 kB (+0.7%)
firestore (Write data)	188 kB	190 kB	+1.29 kB (+0.7%)
firestore-lite (Query Cursors)	81.4 kB	81.4 kB	+17 B (+0.0%)
firestore-lite (Query)	77.6 kB	77.6 kB	+17 B (+0.0%)
firestore-lite (Read data once)	59.8 kB	59.7 kB	-94 B (-0.2%)
firestore-lite (Transaction)	84.5 kB	84.5 kB	+39 B (+0.0%)
firestore-lite (Write data)	69.3 kB	69.4 kB	+14 B (+0.0%)

`firebase`

Type	Base (`a2505bd`)	Merge (`4e07017`)	Diff
firebase-analytics-compat.js	25.8 kB	26.2 kB	+419 B (+1.6%)
firebase-analytics.js	24.9 kB	25.3 kB	+400 B (+1.6%)
firebase-auth-compat.js	126 kB	126 kB	+8 B (+0.0%)
firebase-auth-cordova.js	138 kB	138 kB	+8 B (+0.0%)
firebase-auth-react-native.js	150 kB	150 kB	+8 B (+0.0%)
firebase-auth.js	117 kB	117 kB	+8 B (+0.0%)
firebase-compat.js	747 kB	750 kB	+2.64 kB (+0.4%)
firebase-firestore-compat.js	321 kB	323 kB	+2.21 kB (+0.7%)
firebase-firestore-lite.js	94.2 kB	94.3 kB	+106 B (+0.1%)
firebase-firestore.js	323 kB	327 kB	+3.76 kB (+1.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/o33HpJ3dBT.html

google-oss-bot · 2023-02-22T17:33:49Z

Size Analysis Report ¹

This report is too large (855,698 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/zCmTLUDzxc.html

packages/analytics/src/helpers.ts

packages/analytics/src/helpers.test.ts

packages/analytics/src/helpers.ts

* Updated change set to match Android release notes.

* New way to config Firestore SDK Cache. * fixups * Fix some test failures * Fixing dts file * Add public comments * API report * Create brown-beers-tease.md * warning messages and more tests * Addressing comments * Update API reports * Fix provider test failure for node w/o indexeddb * Fix node memory test * rename cache to localCache * Update API reports * Tech writer review * yarn docgen * auth change * Update API reports * docgen devsite * Fix changeset * Another auth change * more devsite fix * Update API reports * Rename indexeddb to persistent --------- Co-authored-by: wu-hui <[email protected]>

* Change _fail to use NETWORK_REQUEST_FAILED * Add changeset * Check if network error is propagated in error message

…decoding (#7130)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…nce filter (#7134)

Merge issues

hsubox76 · 2023-03-24T20:16:47Z

Merge seems to have pulled in a lot of extraneous files. If you can't resolve it in this branch, I'd suggest starting a fresh branch based on master and copying to it just the files that you changed.

dwyfrequency · 2023-03-27T01:19:24Z

Merge seems to have pulled in a lot of extraneous files. If you can't resolve it in this branch, I'd suggest starting a fresh branch based on master and copying to it just the files that you changed.

Added #7158

Initial fix for Trusted Types failures

4cf1388

Add Trusted-Types

9222f5e

hsubox76 reviewed Feb 22, 2023

View reviewed changes

packages/analytics/src/helpers.ts Outdated Show resolved Hide resolved

dwyfrequency added 4 commits February 22, 2023 18:16

Sanitize input

ac387ac

Add check for gtag url and log error if not found

53781ab

Add test and exported function

6c30bd6

Add changeset

39a6958

dwyfrequency marked this pull request as ready for review March 9, 2023 21:38

dwyfrequency and others added 2 commits March 9, 2023 16:42

Update comment

86c0f2c

Merge branch 'master' into jd-trusted-types-7048

516a70d

hsubox76 reviewed Mar 14, 2023

View reviewed changes

packages/analytics/src/helpers.ts Outdated Show resolved Hide resolved

packages/analytics/src/helpers.test.ts Outdated Show resolved Hide resolved

packages/analytics/src/helpers.ts Outdated Show resolved Hide resolved

dwyfrequency added 2 commits March 21, 2023 16:50

Created function to create policy

dc7b7f1

Stub logger instead of console.log

80ae05e

dwyfrequency changed the title ~~Initial fix for Trusted Types failures~~ Used Trust Types When API is available for gtag URL creation Mar 21, 2023

hsubox76 previously approved these changes Mar 21, 2023

View reviewed changes

packages/analytics/src/helpers.ts Outdated Show resolved Hide resolved

dwyfrequency and others added 12 commits March 22, 2023 12:18

Remove returns keyword in function docstring

ff564c7

Updated the changeset for OR queries to be more descriptive (#7121)

5316071

* Updated change set to match Android release notes.

Enable bundle spec tests for ios (#7096)

f8437f5

Add a TODO (#7103)

715ee9b

Change _fail to use NETWORK_REQUEST_FAILED (#7125)

8bad12d

* Change _fail to use NETWORK_REQUEST_FAILED * Add changeset * Check if network error is propagated in error message

firestore: verify DOMException exists before using it in when base64 …

1794678

…decoding (#7130)

Version Packages (#7123)

c3f3f61

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

remove gapi.auth fall back option for getAuthToken() (#7100)

54035e6

Update dependency simple-git to v3.16.0 [SECURITY] (#6986)

e755eae

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency webpack to v5.76.0 [SECURITY] (#7127)

f8334ae

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update endbug/add-and-commit action to v9 (#6425)

be8b265

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

hsubox76 and others added 4 commits March 23, 2023 11:33

Add changeset (#7137)

cc3c93a

Firestore: query.test.ts: add a test that resumes a query with existe…

b26c072

…nce filter (#7134)

Unmangle a switch variable for Closure (#7136)

8a1f7a4

Remove dependency merge conflicts.

ee6cc36

dwyfrequency requested review from egilmorez, markarndt, erikeldridge, jposuna, avolkovi, yoyomyo, lisajian, prameshj, renkelvin, sam-gc, zwu52, maneesht, tonyjhuang, jsdt and jmwski as code owners March 23, 2023 15:33

Remove duplicate types package

62f0a42

dwyfrequency mentioned this pull request Mar 26, 2023

Used Trusted Types When API is available for gtag URL creation #7155

Merged

dwyfrequency closed this May 23, 2023

firebase locked and limited conversation to collaborators Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Used Trust Types When API is available for gtag URL creation #7052

Used Trust Types When API is available for gtag URL creation #7052

dwyfrequency commented Feb 22, 2023 •

edited

Loading

changeset-bot bot commented Feb 22, 2023 •

edited

Loading

google-oss-bot commented Feb 22, 2023 •

edited

Loading

`@firebase/analytics`

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Feb 22, 2023 •

edited

Loading

hsubox76 commented Mar 24, 2023

dwyfrequency commented Mar 27, 2023

Used Trust Types When API is available for gtag URL creation #7052

Used Trust Types When API is available for gtag URL creation #7052

Conversation

dwyfrequency commented Feb 22, 2023 • edited Loading

changeset-bot bot commented Feb 22, 2023 • edited Loading

🦋 Changeset detected

google-oss-bot commented Feb 22, 2023 • edited Loading

Size Report 1

Affected Products

@firebase/analytics

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

google-oss-bot commented Feb 22, 2023 • edited Loading

Size Analysis Report 1

Test Logs

hsubox76 commented Mar 24, 2023

dwyfrequency commented Mar 27, 2023

dwyfrequency commented Feb 22, 2023 •

edited

Loading

changeset-bot bot commented Feb 22, 2023 •

edited

Loading

google-oss-bot commented Feb 22, 2023 •

edited

Loading

Size Report ¹

`@firebase/analytics`

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Feb 22, 2023 •

edited

Loading

Size Analysis Report ¹