Fix Named export 'Integer' not found
error in es module node project
#7227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Firestore Node bundles now all have a dependency on
@firebase/webchannel-wrapper
(previously, only the "browser" bundles had this dependency). If a project consuming the Firebase SDK does not define"type": "module"
in itspackage.json
, or defines"type": "commonjs"
then the Firestore bundleindex.node.cjs.js
is used. This bundle has the linewhich works.
However, if a project consuming the Firebase SDK does defines "type": "module" then the Firestore bundle
index.node.mjs
is used. This bundle has the linewhich fails at runtime with this error:
This seems to be because the
@webchannel-wrapper
bundleindex.esm2017.js
is being incorrectly loaded as a commonjs module, when, in fact, it is an es module.This PR fixes the problem by simply changing the
.js
extension to.mjs
to indicate that it is an es module and not a commonjs module.