reorganized mfa totp integration tests #7352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelAngelXie
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
prameshj
approved these changes
Jun 8, 2023
AngelAngelXie
deleted the
Fixing-interdependency-in-mfa-totp-Integration-tests-ax
branch
AngelAngelXie
added a commit
that referenced
this pull request
Jun 12, 2023
This reverts commit 713363d.
AngelAngelXie
restored the
Fixing-interdependency-in-mfa-totp-Integration-tests-ax
branch
dwyfrequency
pushed a commit
that referenced
this pull request
Jun 16, 2023
* reorganized mfa totp integration tests * formatted the code * added await for enroll function calls * created fakePassword to store password * fixed typo in mfaUser * moved fakePassword into integration helpers file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the mfa totp integration tests such that the user that is enrolled for mfa will always be unenrolled at the end of each test.
Ran TOTP MFA integration tests against the backend locally. Intentionally added "expect(2).to.equal(200)" in each test.
Also tried adding the false statement into the beforeEach block that enrolls users before the test.
Used curl command to check the status of the user's MFA enrollment.
Successfully verified that the user is unenrolled from MFA at the end despite different test failures.