Make memory lru gc the default #8110

wu-hui · 2024-03-28T18:55:02Z

No description provided.

changeset-bot · 2024-03-28T18:55:06Z

⚠️ No Changeset found

Latest commit: 51cedc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…ndy/MemoryLruDefaul # Conflicts: # packages/firestore/test/integration/util/helpers.ts

google-oss-bot · 2024-04-02T18:52:19Z

Size Report ¹

Affected Products

@firebase/app
Type Base (c6ecac8) Merge (e83ab0b) Diff
browser 18.0 kB 18.1 kB +27 B (+0.1%)
esm5 23.6 kB 23.6 kB +69 B (+0.3%)
main 24.6 kB 24.7 kB +69 B (+0.3%)
module 18.0 kB 18.1 kB +27 B (+0.1%)
@firebase/app-check-compat
Type Base (c6ecac8) Merge (e83ab0b) Diff
browser 2.27 kB 2.27 kB +1 B (+0.0%)
esm5 2.48 kB 2.48 kB +1 B (+0.0%)
main 2.94 kB 2.94 kB +1 B (+0.0%)
module 2.27 kB 2.27 kB +1 B (+0.0%)
@firebase/firestore
Type Base (c6ecac8) Merge (e83ab0b) Diff
browser 376 kB 377 kB +47 B (+0.0%)
esm5 362 kB 362 kB +17 B (+0.0%)
main 580 kB 580 kB +33 B (+0.0%)
module 376 kB 377 kB +47 B (+0.0%)
react-native 377 kB 377 kB +47 B (+0.0%)
@firebase/firestore-lite
Type Base (c6ecac8) Merge (e83ab0b) Diff
browser 109 kB 109 kB +1 B (+0.0%)
esm5 106 kB 106 kB +1 B (+0.0%)
main 150 kB 150 kB +1 B (+0.0%)
module 109 kB 109 kB +1 B (+0.0%)
react-native 109 kB 109 kB +1 B (+0.0%)

`bundle`

46 size changes

Type	Base (`c6ecac8`)	Merge (`e83ab0b`)	Diff
analytics (logEvent)	44.4 kB	44.4 kB	+1 B (+0.0%)
app-check (CustomProvider)	37.3 kB	37.3 kB	+1 B (+0.0%)
app-check (ReCaptchaEnterpriseProvider)	39.8 kB	39.8 kB	+1 B (+0.0%)
app-check (ReCaptchaV3Provider)	39.8 kB	39.8 kB	+1 B (+0.0%)
auth (Anonymous)	76.0 kB	76.0 kB	+2 B (+0.0%)
auth (EmailAndPassword)	84.3 kB	84.3 kB	+2 B (+0.0%)
auth (GoogleFBTwitterGitHubPopup)	103 kB	103 kB	+2 B (+0.0%)
auth (GooglePopup)	100 kB	100 kB	+2 B (+0.0%)
auth (GoogleRedirect)	101 kB	101 kB	+2 B (+0.0%)
auth (Phone)	86.6 kB	86.6 kB	+2 B (+0.0%)
database (Append to a list of data)	149 kB	149 kB	+2 B (+0.0%)
database (Filtering data)	148 kB	148 kB	+2 B (+0.0%)
database (Listen for child events)	164 kB	164 kB	+2 B (+0.0%)
database (Listen for value events + Detach listeners)	164 kB	164 kB	+2 B (+0.0%)
database (Listen for value events)	164 kB	164 kB	+2 B (+0.0%)
database (Read data once)	164 kB	164 kB	+2 B (+0.0%)
database (Save data as transactions)	166 kB	166 kB	+2 B (+0.0%)
database (Sort data)	149 kB	149 kB	+2 B (+0.0%)
database (Write data)	148 kB	148 kB	+2 B (+0.0%)
firestore (CSI Auto Indexing Disable and Delete)	268 kB	271 kB	+2.54 kB (+0.9%)
firestore (CSI Auto Indexing Enable)	268 kB	271 kB	+2.54 kB (+0.9%)
firestore (Persistence)	303 kB	306 kB	+2.54 kB (+0.8%)
firestore (Query Cursors)	247 kB	253 kB	+6.22 kB (+2.5%)
firestore (Query)	245 kB	251 kB	+6.22 kB (+2.5%)
firestore (Read data once)	233 kB	239 kB	+6.22 kB (+2.7%)
firestore (Read Write w Persistence)	323 kB	325 kB	+2.54 kB (+0.8%)
firestore (Realtime updates)	235 kB	241 kB	+6.22 kB (+2.6%)
firestore (Transaction)	212 kB	218 kB	+6.49 kB (+3.1%)
firestore (Write data)	212 kB	218 kB	+6.22 kB (+2.9%)
firestore-lite (Query Cursors)	89.8 kB	89.8 kB	+3 B (+0.0%)
firestore-lite (Query)	85.9 kB	85.9 kB	+3 B (+0.0%)
firestore-lite (Read data once)	62.1 kB	62.1 kB	+3 B (+0.0%)
firestore-lite (Transaction)	87.0 kB	87.0 kB	+3 B (+0.0%)
firestore-lite (Write data)	71.6 kB	71.6 kB	+3 B (+0.0%)
functions (call)	31.8 kB	31.8 kB	+1 B (+0.0%)
messaging (send + receive)	47.2 kB	47.2 kB	+1 B (+0.0%)
performance (trace)	51.6 kB	51.6 kB	+1 B (+0.0%)
remote-config (getAndFetch)	46.2 kB	46.2 kB	+2 B (+0.0%)
storage (getBytes)	42.0 kB	42.0 kB	+2 B (+0.0%)
storage (getDownloadURL)	44.0 kB	44.0 kB	+2 B (+0.0%)
storage (getMetadata)	43.5 kB	43.5 kB	+2 B (+0.0%)
storage (list + listAll)	42.9 kB	42.9 kB	+2 B (+0.0%)
storage (updateMetadata)	43.7 kB	43.7 kB	+2 B (+0.0%)
storage (uploadBytes)	48.6 kB	48.6 kB	+2 B (+0.0%)
storage (uploadBytesResumable)	58.5 kB	58.5 kB	+2 B (+0.0%)
storage (uploadString)	48.8 kB	48.8 kB	+2 B (+0.0%)

`firebase`

22 size changes

Type	Base (`c6ecac8`)	Merge (`e83ab0b`)	Diff
firebase-analytics.js	29.7 kB	29.7 kB	+1 B (+0.0%)
firebase-app-check-compat.js	23.4 kB	23.4 kB	+1 B (+0.0%)
firebase-app-check.js	25.0 kB	25.0 kB	+1 B (+0.0%)
firebase-app-compat.js	31.4 kB	31.4 kB	+12 B (+0.0%)
firebase-app.js	102 kB	102 kB	+54 B (+0.1%)
firebase-auth-cordova.js	177 kB	177 kB	+1 B (+0.0%)
firebase-auth-web-extension.js	117 kB	117 kB	+1 B (+0.0%)
firebase-auth.js	151 kB	151 kB	+1 B (+0.0%)
firebase-compat.js	786 kB	788 kB	+2.51 kB (+0.3%)
firebase-database.js	186 kB	186 kB	+1 B (+0.0%)
firebase-firestore-compat.js	342 kB	344 kB	+2.49 kB (+0.7%)
firebase-firestore-lite.js	117 kB	117 kB	+2 B (+0.0%)
firebase-firestore.js	436 kB	436 kB	+48 B (+0.0%)
firebase-functions.js	11.9 kB	11.9 kB	+1 B (+0.0%)
firebase-installations.js	15.1 kB	15.1 kB	+1 B (+0.0%)
firebase-messaging-sw.js	30.2 kB	30.2 kB	+1 B (+0.0%)
firebase-messaging.js	28.8 kB	28.8 kB	+1 B (+0.0%)
firebase-performance-standalone-compat.es2017.js	93.3 kB	93.3 kB	+13 B (+0.0%)
firebase-performance-standalone-compat.js	70.3 kB	70.3 kB	+36 B (+0.1%)
firebase-performance.js	35.0 kB	35.0 kB	+1 B (+0.0%)
firebase-remote-config.js	29.6 kB	29.6 kB	+1 B (+0.0%)
firebase-storage.js	46.2 kB	46.2 kB	+1 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/yxvXxMFRLj.html

google-oss-bot · 2024-04-02T19:04:26Z

Size Analysis Report ¹

This report is too large (631,311 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/6rOWV6wmNL.html

Make memory lru gc the default

ee4a384

wu-hui requested review from a team as code owners March 28, 2024 18:55

wu-hui added 4 commits March 28, 2024 14:56

undo yarn.lock

839dec4

Make memory lru gc the default

341251c

Fix tests

4ba3360

Merge remote-tracking branch 'origin/wuandy/MemoryLruDefaul' into wua…

51cedc5

…ndy/MemoryLruDefaul # Conflicts: # packages/firestore/test/integration/util/helpers.ts

wu-hui changed the base branch from main to v11 September 9, 2024 18:59

wu-hui requested a review from MarkDuckworth September 9, 2024 19:00

wu-hui assigned MarkDuckworth Sep 9, 2024

MarkDuckworth approved these changes Sep 9, 2024

View reviewed changes

wu-hui merged commit a377fb2 into v11 Sep 9, 2024
44 checks passed

wu-hui deleted the wuandy/MemoryLruDefaul branch September 9, 2024 22:10

firebase locked and limited conversation to collaborators Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make memory lru gc the default #8110

Make memory lru gc the default #8110

wu-hui commented Mar 28, 2024

changeset-bot bot commented Mar 28, 2024 •

edited

Loading

google-oss-bot commented Apr 2, 2024

`@firebase/app`

`@firebase/app-check-compat`

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Apr 2, 2024

Make memory lru gc the default #8110

Make memory lru gc the default #8110

Conversation

wu-hui commented Mar 28, 2024

changeset-bot bot commented Mar 28, 2024 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Apr 2, 2024

Size Report 1

Affected Products

@firebase/app

@firebase/app-check-compat

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

google-oss-bot commented Apr 2, 2024

Size Analysis Report 1

Test Logs

changeset-bot bot commented Mar 28, 2024 •

edited

Loading

Size Report ¹

`@firebase/app`

`@firebase/app-check-compat`

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

Size Analysis Report ¹