Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Implicit Null Parameters #582

Closed
Zykaris opened this issue Nov 21, 2024 · 2 comments
Closed

Deprecated Implicit Null Parameters #582

Zykaris opened this issue Nov 21, 2024 · 2 comments

Comments

@Zykaris
Copy link

Zykaris commented Nov 21, 2024

Obviously this is pretty new, but with the general release of PHP 8.4.1 today, implicit null parameters now raise warnings. These warnings all say something similar to the following:

PHP Deprecated: Firebase\JWT\JWT::decode(): Implicitly marking parameter $headers as nullable is deprecated, the explicit nullable type must be used instead

This occurs in--at least--the following places:

  1. src\JWK.php on line 55
  2. src\JWK.php on line 96
  3. src\JWT.php on line 96
  4. src\JWT.php on line 203
  5. src\JWT.php on line 204

Once Null is added to the type-hints, the library appears to work without issue.

@sbuerk
Copy link

sbuerk commented Nov 23, 2024

Should be aready fixed with #572 which is merged. Sadly, still a release is missing #578

I'd say this can be closed as duplicate of #570

@Zykaris
Copy link
Author

Zykaris commented Nov 25, 2024

Duplicate of #570

@Zykaris Zykaris closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants