Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings on PHP 8.4 #570

Closed
ADmad opened this issue Jul 25, 2024 · 2 comments · Fixed by #572
Closed

Deprecation warnings on PHP 8.4 #570

ADmad opened this issue Jul 25, 2024 · 2 comments · Fixed by #572

Comments

@ADmad
Copy link

ADmad commented Jul 25, 2024 

src/JWT.php:199
Firebase\JWT\JWT::encode(): Implicitly marking parameter $keyId as nullable is deprecated, the explicit nullable type must be used instead

src/JWK.php:55
Firebase\JWT\JWK::parseKeySet(): Implicitly marking parameter $defaultAlg as nullable is deprecated, the explicit nullable type must be used instead

src/JWK.php:96
Firebase\JWT\JWK::parseKey(): Implicitly marking parameter $defaultAlg as nullable is deprecated, the explicit nullable type must be used instead
sbuerk added a commit to sbuerk/php-jwt that referenced this issue Jul 26, 2024
@sbuerk
chore: Mitigate PHP8.4 deprecation warnings (firebase#570)
7c7f4bc
@sbuerk sbuerk mentioned this issue Jul 26, 2024
Merged
@lolli42
Copy link

lolli42 commented Jul 29, 2024

Confirmed. Would be great to get this merged and released - PHP 8.4 is alpha2 now and frameworks start implementing compatibility, libraries should have compatible releases.

@lolli42
Copy link

lolli42 commented Aug 6, 2024 •
edited
Loading

Ping.

Note current CI is (unnoticed) red, which is fixed by PR #572 as well as drive-by.

Note there is PR #573 as dupe already.

reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this issue Aug 9, 2024
@lolli42 @maddy2101
[TASK] Activate PHP 8.4 unit tests
048a1db 
We want to go ahead with PHP 8.4 compatibility and
activate unit tests using PHP 8.4 alpha 4 in CI.

Dependencies triggered by unit tests are mainly
ready and raised already, except firebase/php-jwt:

They merged an according patch, but did not release
yet [2]. We - for now - composer-patch this dependency
in order to focus on PHP 8.4 support in other test
suites like functionals, while being backed by green
unit tests in CI already. The applied patch is the
8.4 part of firebase/php-jwt PR #572 [1], which has
been squashed to dev-main by the maintainers with
another commit we had to submit to greenify their CI
along the way.

CI pre-merge tests now unit test "locked" 8.2 and 8.4,
skipping 8.3. 8.3 "locked" is added to nightly instead,
along with 8.4 "max". 8.4 "min" is not added since
the transitive dependencies 'symfony/string' and
'symfony/cache' are not 8.4 ready in their "min"
versions.

> composer config --no-plugins --no-interaction allow-plugins.cweagans/composer-patches true
> composer config --no-plugins --no-interaction extra.composer-exit-on-patch-failure true
> composer config --no-plugins --no-interaction extra.patches-file "Build/patches/patches.json"
> composer require --dev "cweagans/composer-patches":"^1.7.3"
> composer req firebase/php-jwt:^6.10.1

[1] firebase/php-jwt@7c7f4bc
[2] firebase/php-jwt#570

Resolves: #104578
Releases: main
Change-Id: I5686ef100571434aad4dfd352742d15028e7b1b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85562
Tested-by: Anja Leichsenring <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
Tested-by: Benni Mack <[email protected]>
Reviewed-by: Benni Mack <[email protected]>
Reviewed-by: Anja Leichsenring <[email protected]>
Tested-by: core-ci <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
TYPO3IncTeam pushed a commit to TYPO3-CMS/core that referenced this issue Aug 9, 2024
@lolli42 @maddy2101
[TASK] Activate PHP 8.4 unit tests
18060ac 
We want to go ahead with PHP 8.4 compatibility and
activate unit tests using PHP 8.4 alpha 4 in CI.

Dependencies triggered by unit tests are mainly
ready and raised already, except firebase/php-jwt:

They merged an according patch, but did not release
yet [2]. We - for now - composer-patch this dependency
in order to focus on PHP 8.4 support in other test
suites like functionals, while being backed by green
unit tests in CI already. The applied patch is the
8.4 part of firebase/php-jwt PR #572 [1], which has
been squashed to dev-main by the maintainers with
another commit we had to submit to greenify their CI
along the way.

CI pre-merge tests now unit test "locked" 8.2 and 8.4,
skipping 8.3. 8.3 "locked" is added to nightly instead,
along with 8.4 "max". 8.4 "min" is not added since
the transitive dependencies 'symfony/string' and
'symfony/cache' are not 8.4 ready in their "min"
versions.

> composer config --no-plugins --no-interaction allow-plugins.cweagans/composer-patches true
> composer config --no-plugins --no-interaction extra.composer-exit-on-patch-failure true
> composer config --no-plugins --no-interaction extra.patches-file "Build/patches/patches.json"
> composer require --dev "cweagans/composer-patches":"^1.7.3"
> composer req firebase/php-jwt:^6.10.1

[1] firebase/php-jwt@7c7f4bc
[2] firebase/php-jwt#570

Resolves: #104578
Releases: main
Change-Id: I5686ef100571434aad4dfd352742d15028e7b1b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85562
Tested-by: Anja Leichsenring <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
Tested-by: Benni Mack <[email protected]>
Reviewed-by: Benni Mack <[email protected]>
Reviewed-by: Anja Leichsenring <[email protected]>
Tested-by: core-ci <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
@sbuerk sbuerk mentioned this issue Nov 23, 2024
Closed
@release-please release-please bot mentioned this issue Nov 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Prepare towards PHP8.4 compatibility sbuerk/php-jwt
2 participants
@ADmad @lolli42