Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a list of strings as header value in JWT::encode() #595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

herndlm
Copy link

@herndlm herndlm commented Mar 21, 2025

Fixes #593

In our case we need to be able to set the crit claim for a third party webservice. Found more info about crit here: https://mojoauth.com/glossary/jwt-critical/

Copy link

google-cla bot commented Mar 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@herndlm
Copy link
Author

herndlm commented Mar 21, 2025

I don't have a google account associated with my email and don't want to create one. I'm ok with the CLA though. anyway, anybody feel free to take over this fix if possible. I also don't care if this is copied from me without mentioning me (e.g. @hultberg)..

that's how you make things hard in OSS with weird processes 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: JWT::encode $headers expects array of strings
1 participant