Need for build speed! #289
Conversation
build.sh
Outdated
| else | ||
| # On a pull request, just build debug which is much faster and catches | ||
| # obvious errors. | ||
| GRADLE_OPTS=$OPTS ./gradlew clean :app:assembleDebug | ||
| ./gradlew clean assembleDebug |
There was a problem hiding this comment.
The other important thing we do that I forgot to mention explicitly is that all modules are built in single Travis build. Since they don't depend on each other, we can build them in parallel without taking a performance hit which is faster than booting up a bunch of Travis VMs and redownloading stuff.
invites/app/build.gradle
Outdated
| main { | ||
| // TODO(developer): Replace this with your app code | ||
| // See: https://firebase.google.com/docs/dynamic-links/android | ||
| resValue "string", "app_code", "YOUR_APP_CODE" |
There was a problem hiding this comment.
TODO(me): This is only used in a test, figure out why.
There was a problem hiding this comment.
We need to keep this. These samples are actually cloned and built by another team at Google and used for end-to-end Firebase testing and they requested we use this app_code in gradle config to make their lives easier.
There was a problem hiding this comment.
Ah crud, that's makes life harder because we need to add a dimension. Let's see if I can get it to work! 😄
|
@samtstern Aw man, there's a bug when building stuff in parallel so we're up to ~6m build time now. 😢 |
admob/app/build.gradle
Outdated
|
|
||
| // [START gradle_play_config] | ||
| compile 'com.google.firebase:firebase-ads:11.0.1' | ||
| implementation 'com.google.firebase:firebase-ads:11.0.1' |
There was a problem hiding this comment.
I'm fine to move to the 3.0 plugin but could we move these back to compile throughout? Many developers using this project as a reference are not on the 3.0 tools yet and implementation will not work for them if they copy and paste (which everyone does).
There was a problem hiding this comment.
K, sounds reasonable. Do you want that for each module or just the admob one?
|
@SUPERCILEX wow thank you for doing all this! That's some serious speed. Left one comment. |
|
@samtstern Bringing along the improvements from FirebaseUI, I also added compiling tests to the Speaking of tests, everything compiles locally and all the tests pass except for an auth one. I'm pretty that's not my fault, but could you try running |
|
@SUPERCILEX I am pretty sure some of the tests are broken, you're right. So let's leave them out of this PR for the sake of greenness! |
|
@samtstern K, SGTM. |
|
@samtstern I took one last look at everything and I believe #289 (comment) is the only thing left to resolve. |
|
Oh, just saw your comment. I'm on it. |
|
@samtstern Cool beans, I think I reverted everything correctly! (I need to file a bug with Tor to provide some sort of Android Studio quick-fix to update the compile notation 😄) |
|
The final build: "Ran for 6 min 50 sec" @SUPERCILEX you're a legend, thank you! |
|
Haha, thanks! 😀 |
@samtstern at a high level overview, this PR does a few things:
fixes #288