FIR-28289 Change SUBSTRING's <start> and <count> parameters to BIGINT #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackDB PR: https://github.com/firebolt-analytics/packdb/pull/8531 .
We used to define the signature of
substring
function following PostgreSQL, which has<start>
and<count>
parameters defined asINTEGER
. Callingsubstring
withBIGINT
values for these parameters fail in PostgreSQL, and we kept the same behavior.However, we agreed that this is not very convenient. Supporting
BIGINT
types for these parameters should be a natural extension. It does not hurt our "PostgreSQL compliant" claim. In addition, given that we still produceBIGINT
for arithmetic addition of integers, this is just convenient for our user to make in-position call to other functions.