fix: Boolean false value on inputs breaks configuration syntax #1529
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firecow
reviewed
Mar 19, 2025
src/parser.ts
Outdated
Comment on lines
412
to
413
| const inputValue = inputs[interpolationKey] | ||
| ?? inputsSpecification.spec.inputs[interpolationKey]?.default; |
There was a problem hiding this comment.
Suggested change
| const inputValue = inputs[interpolationKey] | |
| ?? inputsSpecification.spec.inputs[interpolationKey]?.default; | |
| const inputValue = inputs[interpolationKey] ?? inputsSpecification.spec.inputs[interpolationKey]?.default; |
There was a problem hiding this comment.
firecow
reviewed
Mar 19, 2025
Comment on lines
+257
to
+267
| const expected = `--- | ||
| stages: | ||
| - .pre | ||
| - test | ||
| - .post | ||
| scan-website: | ||
| script: | ||
| - echo false`; | ||
|
|
||
| expect(writeStreams.stdoutLines[0]).toEqual(expected); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const expected = `--- | |
| stages: | |
| - .pre | |
| - test | |
| - .post | |
| scan-website: | |
| script: | |
| - echo false`; | |
| expect(writeStreams.stdoutLines[0]).toEqual(expected); | |
| }); | |
| const expected = [ | |
| "---", | |
| "stages:", | |
| " - .pre", | |
| " - test", | |
| " - .post", | |
| "scan-website:", | |
| " script:", | |
| " - echo false", | |
| ]; | |
| expect(writeStreams.stdoutLines[0]).toEqual(expected.join("\n")); | |
| }); |
There was a problem hiding this comment.
I have been doing the backticks versions in multiple places...
personally i prefer the backticks version because for ease of (typing/copy pasting)...
what's your perspective in this ?
There was a problem hiding this comment.
I don't prefer the weird indentation or backticks, but I can live with both 😄
firecow
approved these changes
Mar 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1528