Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings with rust 1.37 #1277

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

petreeftime
Copy link
Contributor

@petreeftime petreeftime commented Sep 22, 2019

Reason for This PR

Rust 1.37 warns about using Trait instead of dyn Trait (rust-lang/rust#61203) and inclusive ranges with ... syntax ranges instead of ..= syntax (rust-lang/rust#28237).

Description of Changes

I've fixed the specific instances where these two warnings appear in the firecracker code.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

[Author TODO: Meet these criteria. Where there are two options, keep one.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • Either this PR is linked to an issue, or, the reason for this PR is
    clearly provided.
  • The description of changes is clear and encompassing.
  • Either no docs need to be updated as part of this PR, or, the required
    doc changes are included in this PR. Docs in scope are all *.md files
    located either in the repository root, or in the docs/ directory.
  • Either no code has been touched, or, code-level documentation for touched
    code is included in this PR.
  • Either no API changes are included in this PR, or, the API changes are
    reflected in firecracker/swagger.yaml.
  • Either the changes in this PR have no user impact, or, the changes in
    this PR have user impact and have been added to the CHANGELOG.md file.

@dianpopa dianpopa merged commit d01a698 into firecracker-microvm:master Sep 23, 2019
@petreeftime petreeftime deleted the fix-warnings branch September 23, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants