Prepare Firecracker v1.5.1 #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.5 #4277 +/- ##
=================================================
Coverage 83.02% 83.02%
=================================================
Files 223 223
Lines 28494 28493 -1
=================================================
Hits 23656 23656
+ Misses 4838 4837 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
previously approved these changes
Nov 28, 2023
pb8o
force-pushed
the
firecracker-v1.5
branch
from
8639216 to
a5c73e9
Compare
pb8o
added
Status: Awaiting review
|
some of the commits are missing where they were cherrypicked from, it will help to understand if a commit was cherry-picked or a new fix. |
Yes, the release fixes only exist in this branch at the moment. Depending on this release experience, we will forward port them to the |
wearyzen
previously approved these changes
Nov 28, 2023
roypat
previously approved these changes
Nov 30, 2023
pb8o
force-pushed
the
firecracker-v1.5
branch
from
a5c73e9 to
18cc8e9
Compare
Move the message after the logger has been configured, so it actually gets printed. Eliminate redundant message that outputs internal vmm crate version 0.1.0. Fixes: 96ed457, 332f218 (cherry picked from commit 78c26af) Signed-off-by: Pablo Barbáchano <[email protected]>
show-log-origin was turned on by the --show-level option. Use the correct flag to enable it. Fixes: 332f218 (cherry picked from commit 22eb608) Signed-off-by: Pablo Barbáchano <[email protected]>
This enables us to run a pipeline against an existing binary. The binary has to exist in the Buildkite artifacts buckets. Signed-off-by: Pablo Barbáchano <[email protected]>
The tests will be run at a later stage as part of the release automation. Signed-off-by: Pablo Barbáchano <[email protected]>
Fix missing brackets and add snapshot-editor. Signed-off-by: Pablo Barbáchano <[email protected]>
Add PR link to changelog. Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o
force-pushed
the
firecracker-v1.5
branch
from
18cc8e9 to
cb97e36
Compare
roypat
reviewed
Dec 4, 2023
pb8o
force-pushed
the
firecracker-v1.5
branch
from
cb97e36 to
87eab6b
Compare
That way it won't leave the repo in an inconsistent state. It is supported by GitHub[1]. [1]: https://github.blog/2015-04-30-git-2-4-atomic-pushes-push-to-deploy-and-more/ Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o
force-pushed
the
firecracker-v1.5
branch
2 times, most recently
from
d899c93 to
8059f83
Compare
roypat
previously approved these changes
Dec 4, 2023
xmarcalx
requested changes
Dec 4, 2023
pb8o
force-pushed
the
firecracker-v1.5
branch
from
8059f83 to
87c2049
Compare
Document the issue in firecracker-microvm#4287 so customers are aware of it. We will continue working on providing a resolution for it. Signed-off-by: Pablo Barbáchano <[email protected]>
Set the release date as today. Signed-off-by: Pablo Barbáchano <[email protected]>
Update version number / CHANGELOG / CREDITS Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o
force-pushed
the
firecracker-v1.5
branch
from
87c2049 to
588090f
Compare
xmarcalx
approved these changes
Dec 4, 2023
roypat
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prepare v1.5.1 release
Reason
Added
Document a caveat to the jailer docs when using the
--parent-cgroupoption,which results in it being ignored by the jailer. Refer to the jailer
documentation for a workaround.
Changed
Refactored error propagation to avoid logging and printing an error on
exits with a zero exit code. Now, on successful exit
"Firecracker exited successfully" is logged.
Fixed
bug that ignored the
--show-log-originoption, preventing it from printingthe source code file of the log messages.
Fixed a bug reporting a non-zero exit code on successful shutdown when
starting Firecracker with
--no-api.a bug where Firecracker would log "RunWithApiError error: MicroVMStopped
without an error: GenericError" when exiting after encountering an emulation
error. It now correctly prints "RunWithApiError error: MicroVMStopped with an
error: GenericError".
Fixed a bug introduced in Update logger #4047 that limited the
--leveloption of loggerto Pascal-cased values (e.g. accepting "Info", but not "info"). It now
ignores case again.
Fixed a bug in the asynchronous virtio-block engine that rendered the device
non-functional after a PATCH request was issued to Firecracker for updating
the path to the host-side backing file of the device.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.