gui: use string for large ints in json #4617
Open
+450
−435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.parse
for typical js clients will automatically parse any number as a javascriptnumber
, which can store numbers smaller than ~2^53 without loosing accuracy. For numbers we expect to be larger than this (i.e. timestamps and lamports), we should explicitly use strings. Application code and convert tobigint
as needed.