Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an additional check on the upper bound of the shred34 shred count #4629

Merged
merged 1 commit into from
Mar 28, 2025
Merged

add an additional check on the upper bound of the shred34 shred count #4629

merged 1 commit into from
Mar 28, 2025

Conversation

marcograss
Copy link
Contributor

shred34 can contain up to 34 shreds, so a check was added to enforce this

@nlgripto nlgripto requested a review from ptaffet-jump March 25, 2025 15:06
ptaffet-jump
ptaffet-jump reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@ptaffet-jump ptaffet-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you make it a single & here? No need for short circuit behavior on this conditional statement.

@marcograss
Copy link
Contributor Author

Thanks. Could you make it a single & here? No need for short circuit behavior on this conditional statement.

Thanks for the feedback I updated the PR

@ptaffet-jump ptaffet-jump added this pull request to the merge queue Mar 28, 2025
Merged via the queue into firedancer-io:main with commit 818106e Mar 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptaffet-jump ptaffet-jump ptaffet-jump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcograss @ptaffet-jump