Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and cleaning up the publishing process #301

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

julienw
Copy link

@julienw julienw commented Mar 19, 2025

This adds some documentation about the publishing process.
This also changes the script prepublishOnly to prepack when publishing. Both are run currently so it's really a no-op, but I've noticed that more recent versions of yarn only does prepack, so this looks more correct.
I also updated the content of this script to make sure the dependencies are uptodate before building.

@julienw julienw requested a review from canova March 19, 2025 15:14
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for firefox-devtools-react-contextmenu ready!

Name Link
🔨 Latest commit 6e8cd30
🔍 Latest deploy log https://app.netlify.com/sites/firefox-devtools-react-contextmenu/deploys/67dadf401ba4e500082b2c5d
😎 Deploy Preview https://deploy-preview-301--firefox-devtools-react-contextmenu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92
Accessibility: 82
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't remember having to disable the branch protection part. So it's good to have this. I was thinking if we can do the same thing without it, but probably this is easier to do.
I usually push my tags with git push upstream --tags without the HEAD so it only pushes the tags, but I forgot the commit that publish generates. We still need to push it somehow.

@julienw julienw merged commit 2d55e89 into firefox-devtools:master Mar 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants