Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: create or merge user #26

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

wilsonehusin
Copy link
Member

@wilsonehusin wilsonehusin commented May 1, 2024

pre-create-user.mov

@wilsonehusin wilsonehusin force-pushed the wh/multi-select-import-user branch from 53cb647 to bd03328 Compare May 1, 2024 15:42
@wilsonehusin wilsonehusin force-pushed the wh/multi-select-import-user branch from bd03328 to e3a9c23 Compare May 9, 2024 00:42
@wilsonehusin wilsonehusin changed the title import: create or merge user, wip import: create or merge user May 9, 2024
@wilsonehusin wilsonehusin marked this pull request as ready for review May 9, 2024 00:49
@wilsonehusin wilsonehusin requested review from AlexisJasso and a team May 9, 2024 00:49
Copy link

@dmleong dmleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent you one non-blocking comment over DM but otherwise looks good 👍

payload := map[string]any{
"userName": u.Username(),
"name": map[string]any{
"familyName": u.FamilyName(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice touch to include either family name or given name

@@ -0,0 +1,145 @@
{
"data": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DM'd you a comment

@wilsonehusin wilsonehusin merged commit b33eb82 into main May 9, 2024
4 checks passed
@wilsonehusin wilsonehusin deleted the wh/multi-select-import-user branch May 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants