pager/og: safer teamID retrieval
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like Opsgenie doesn't guarantee OwnerTeam to be present.
wilsonehusin
commented
May 14, 2024
| for _, u := range unmatched[i:] { | ||
| for _, u := range toImport[i:] { |
There was a problem hiding this comment.
this bug caused us to provision everyone regardless of the people who were selected 🙃 i'm going to follow up with a refactor + test. this is a quick fix for now.
| @@ -211,6 +212,8 @@ func (c *Client) CreateUser(ctx context.Context, u SCIMUser) (*store.FhUser, err | |||
| return nil, fmt.Errorf("creating user: %w", err) | |||
| } | |||
| if resp.StatusCode != http.StatusCreated { | |||
| body, _ := io.ReadAll(resp.Body) | |||
| console.Errorf("unexpected status code %d: %s\n", resp.StatusCode, body) | |||
There was a problem hiding this comment.
log more information when response code isn't expected — this should help users get better information and can help us figure out where to look.
| if policy.Repeat != nil { | ||
| repeatLimit = int64(policy.Repeat.Count) | ||
| repeatInterval.Valid = true | ||
| repeatInterval.String = fmt.Sprintf("PT%dM", policy.Repeat.WaitInterval) | ||
| } | ||
| teamID := sql.NullString{} | ||
| if policy.OwnerTeam != nil { |
There was a problem hiding this comment.
this is apparently nil-able, which would cause panic
There was a problem hiding this comment.
Why? And how? But these are things we're not meant to know I guess and we just accept them so here we are.
AlexisJasso
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received a user report error on this:
Seems like Opsgenie doesn't guarantee OwnerTeam to be present.