Expose bit resolution of ADC, PWM (and others as available) #149
Conversation
Signed-off-by: Rick Waldron <[email protected]>
| @@ -505,6 +523,12 @@ function Board(port, options, callback) { | |||
| RES_TX3: 0x07, | |||
| }; | |||
|
|
|||
| this.RESOLUTION = { | |||
| ADC: null, | |||
There was a problem hiding this comment.
What happens if the user skips the configurationQuery? Do we need defaults values set here instead?
There was a problem hiding this comment.
I guess another way to think about this is do the default values live in firmata.js or in johnny-five (where the normalization of analog and pwm values takes place).
There was a problem hiding this comment.
This is the only place in firmata.js where there is a reference to the resolution: https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L740. If we set defaults in firmata.js that param description could change to something like:
"The data to write to the pin between 0 and this.RESOLUTION.PWM."
There was a problem hiding this comment.
What happens if the user skips the configurationQuery? Do we need defaults values set here instead?
That's reasonable, we should just use Arduino defaults. (update shortly)
If we set defaults in firmata.js that param description could change to something like:
"The data to write to the pin between 0 and this.RESOLUTION.PWM."
Sounds good
There was a problem hiding this comment.
I like this better than my stab at it :)
👍
rwaldron
force-pushed
the
resolution-alternative
branch
from
61ae483 to
36b37c7
Compare
Signed-off-by: Rick Waldron <[email protected]>
rwaldron
force-pushed
the
resolution-alternative
branch
from
36b37c7 to
6c1ec84
Compare
4 similar comments
|
LGTM |
|
@soundanalogous @monteslu thanks for reviewing |
Simplified mechanism for exposing resolution values from capabilities response. Intended to supersede #144
Signed-off-by: Rick Waldron [email protected]