This repository was archived by the owner on Mar 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Bump-Scoped rendering and SVG class attribute fix #136
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
22a053f
Removed special-cased set_class to support class attribute on SVG
awestlake87 422bcbf
Changed Render trait to allow bump-scoped lifetimes in components
awestlake87 7489e4e
Fixed examples after change to Render trait
awestlake87 712c2ec
Fixed minor warning about unused cx in test
awestlake87 330045a
Fixed some targets that weren't getting built before
awestlake87 a800634
Plumbed is_namespaced through to the set_attribute function to preser…
awestlake87 953ed2e
Fixed tests and benches after checking Travis CI logs
awestlake87 e54519c
Added regression test for SVG 'class' attribute
awestlake87 788c762
Fixed typo
awestlake87 4b01fe7
Added render test for bump-scoped nodes
awestlake87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the smoke test. It's pretty similar to the other one, but I used the
assert_rendered
afterward