Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and improve internal iteration support #71

Merged
merged 2 commits into from
Apr 14, 2019
Merged

Conversation

novacrazy
Copy link
Collaborator

In the latest "This Week in Rust", one update to Rust core was to use for_each where possible on a few things to allow complex iterators to use specialized behavior in the form of fold to improve performance.

So, in this PR (aside from a few changes due to rustfmt updates) it is now using internal iteration via for_each wherever possible, and I've implemented a specialized fold on GenericArrayIter to allow faster traversal of it inside for_each.

@novacrazy novacrazy requested a review from fizyk20 April 10, 2019 17:33
Copy link
Owner

@fizyk20 fizyk20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@novacrazy novacrazy merged commit 0a46a93 into master Apr 14, 2019
@novacrazy novacrazy deleted the internal_iteration branch April 14, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants