Skip to content

CI - Fix Building(CMake) on Windows 2019 #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

volovikariel
Copy link
Contributor

@volovikariel volovikariel commented Feb 27, 2025

Motivation: I don't want CI builds to fail (see #3851). This PR addresses the Windows 2019 Building(CMake) failures.

Problem analysis: Windows 2019 Building(CMake) runs are failing for us: https://github.com/flameshot-org/flameshot/actions/runs/13554611383/job/37886033174

Image

The failures occur in the QT Install step:

- name: Install Qt
uses: jurplel/install-qt-action@v2
with:
version: 5.15.2
target: desktop
dir: '${{ github.workspace }}/build/'

I spent some time looking into it, and it looks like jurplel/install-qt-action is was also having issues with python version 3.13. See this commit, which limits their python versions to 3.12 now: jurplel/install-qt-action@fc214cc

Image

Proposed solution:
Going from jurplel/install-qt-action@v2 to jurplel/install-qt-action@v4 should fix the issue (as their commit was made to v4).

My tests:
This change seems to make the build pass: https://github.com/volovikariel/flameshot/actions/runs/13568251686/job/37926340193?pr=7
image

`jurplel/install-qt-action` provides a fix to Windows 2019 runners in commit `fc214ccc2dadadaebf48e8e5ed6ff4297dfbb732`, which is in `v4`.

This fix will prevent our CI runs from failing, as they attempt to run with python 3.13 and that causes issues.
Remove QEMU dummy package installation from Linux-pack.yml (flameshot-org#3851)
@mmahmoudian
Copy link
Member

Thanks for the PR and detailed explanation of your investigation. I went somewhat down the rabbit-hole some weeks back, but I didn't dive until the end (i.e. into the jurplel/install-qt-action. This was educational for me. Thanks.

@mmahmoudian mmahmoudian merged commit 73aad3c into flameshot-org:master Mar 4, 2025
24 of 28 checks passed
@mmahmoudian
Copy link
Member

Well, checking my local git diff says that I narrowed it down to jurplel/install-qt-action but just bumped the version one up hoping to fix the issue, which didn't and therefore no PR 😅

image

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants