Improve the speed of calling grim #3859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmahmoudian hi, looks like you're the most active maintainer... would you mind giving this a review? |
|
It works. Still not perfect but way faster. Environment: Linux, hyprland Possibly could also help with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the output file is specified in the "ppm" format, Grim can operate more efficiently. Additionally, loading a pixmap from a file is significantly faster than retrieving it from standard output. In my test, this optimization can reduce the time by approximately 150 milliseconds.
old method:
new method:
Already tested this change on archlinux with hyprland.