Skip to content

Bumped minimum Cmake version to fix build issues on Cmake 4.0. #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

borgmanJeremy
Copy link
Contributor

This resolves the aur issue building flameshot-git. Flameshot also will fail to build in arch until this is bumped. Cmake 3.22 was chosen since that is the version on Ubuntu 22.04.

Ideally all the external dependencies need refreshed, but that's much more work.

…as chosen since that is the version on Ubuntu 22.04
Copy link

@FelixJochems FelixJochems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround

I think the original project has since moved to gitlab. I'll see if we can do an in place upgrade.

Edit: just checked, seems like updating the qt-colors widget isn't supercomplicated. I'll raise a PR at the end of the weekend

@mmahmoudian
Copy link
Member

We should remove the Ubuntu 20.04 as it is EOL by the end of this month, but I can't figure out why the Debian 11 CIs are failing

@borgmanJeremy
Copy link
Contributor Author

borgmanJeremy commented Apr 6, 2025 via email

@mmahmoudian mmahmoudian merged commit 5c8244f into flameshot-org:master Apr 7, 2025
24 of 25 checks passed
@mmahmoudian
Copy link
Member

@borgmanJeremy Thanks for checking it out. It was bugging me why it fails and I couldn't figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants