Add config option to open grabber instead of panel from color picker

[Forkelt]

This adds a checkbox to have the custom "picker" option in the colour picker immediately open and use the colour grabber instead of the side panel.

I find myself quite often wanting to use on-screen colours when editing in flameshot, and using the side panel for it is a bit more cumbersome than necessary, this option alleviates that by allowing use of the grabber directly, while the side panel remains available through usual means.

[mmahmoudian]

@Forkelt

Thanks for the PR. We usually prefer to have the features first discussed before having the PR. But thanks for the code. It makes sense to me and I think the is a good improvement. Let's get other devs' opinions and reviews.

@panpuchkov @FelixJochems @veracioux @jack9603301 what do you folks think about this and if you are positive about the change, can you also review the code.

[b0ch3nski]

Generally I also find myself quite often in the situation where I'd like to grab the color quickly, but in the same time using colors from the palette 😄

Maybe you could modify the UX a little bit and add a picker button somewhere in the palette (in the middle maybe?). That could be enabled for everyone by default as it wouldn't break any previous usage patterns (so no new config option needed).

What do you think?

[Forkelt]

I had some other ideas about how this might be implemented, such as by adding a new option to the palette like @b0ch3nski mentioned, but from what I saw there's quite a bit that would have to be changed in how the picker works to enable that.

In general, I think opening the side panel from the picker makes very little sense, and the only reason I think for it doing that is because that's where the palette sits, but the side panel is a bit overkill for just that purpose. I think it might make more sense for the picker to open the palette by itself on screen, with perhaps the grabber button still present? But again, this would be a much more significant change (and would definitely require some consensus on whether that's a desirable functionality).

@mmahmoudian if the maintainers think this might be worth further discussion to find a better solution which might not have to add extra config options either, I'd be happy to engage in that. Apologies for the "cold PR", I believed it to be a relatively uncontroversial change and it wasn't a great deal of work.

[b0ch3nski]

Thanks @Forkelt for the explanation. I'm totally fine with both your current change in this PR and your other idea, although I'm not a maintainer 🙂

IMO it makes great sense to get the color picker closer to the color palette itself.