This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Removes OFAC blacklist feature. #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
* Add block build trigger from beacon node * remove empty block building Co-authored-by: avalonche <[email protected]>
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
flashbots#123) * Discard reverting megabundle blocks and head change interrupted blocks * Discard all blocks with incomplete bundles * Run reverting megabundles regression test separately from bundle tests
* Rework payment tx * move env access from worker * add builder.dry-run * Move proposer tx from fillTransactions * Use one flag for validation blocklist
* Backport improvements to the builder from incremental improvements * Make linter happy
Use batch queries for upserting data on built blocks. Include more data on the built blocks - sealing time, orderflow cutoff time, and include data for all bundles considered.
* Remove old infra scripts * core: tx_pool not return `error` in `MevBundles()` * Adjust worker to not consider error returned from MevBundles * Update web3ext.go * internal/ethapi: Fix context not being used * fix: dev: add defer privateTx.Stop() Co-authored-by: eugene <[email protected]> Co-authored-by: 0x2 <[email protected]> Co-authored-by: Nicolas Gotchac <[email protected]> Co-authored-by: Jolly Zhao <[email protected]>
* update readme * add bundle movement (flashbots#50) * Add builder diagram Co-authored-by: Bhakiyaraj Kalimuthu <[email protected]> Co-authored-by: Mateusz Morusiewicz <[email protected]>
Update README.md
* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (flashbots#4) * Validate that the coinbase and feeRecipient are not blacklisted (flashbots#5) * Validate that the proposer payment has no calldata and its gas usage (flashbots#6) * Validate gas limit is set correctly wrt registered (flashbots#8) * Pass validation-specific config (flashbots#9)
Software built for Ethereum should be designed with the Ethereum ethos in mind, which has a strong focus on censorship resistance. This means not including features that make it easy for people to censor. While we cannot stop block builders from censoring, we can at least make it difficult for them to do so by not doing all of the work of writing censorious software for them. This PR removes the blacklisting feature, thus making it so the off-the-shelf defaults used by a builder are non-censoring.
|
Note: I believe this includes all of the changes necessary to remove this feature, but I don't have a Go dev environment setup so I can't easily be sure. Whoever reviews this should clone it locally and make sure it compiles without error. |
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
|
PR #56 is not a replacement for this PR at all. #56 just removes the example blacklist, while this PR removes the entire blacklist feature. The entire point of this PR was to remove the ability to blacklist while using off the shelf software (force people to have to maintain a fork if they want to be bad) and removing just the example does not achieve that. I recommend this be re-opened. |
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Software built for Ethereum should be designed with the Ethereum ethos in mind, which has a strong focus on censorship resistance. This means not including features that make it easy for people to censor. While we cannot stop block builders from censoring, we can at least make it difficult for them to do so by not doing all of the work of writing censorious software for them.
This PR removes the blacklisting feature, thus making it so the off-the-shelf defaults used by a builder are non-censoring.
CONTRIBUTING.md