Skip to content

feat: Interop support from reth #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: Interop support from reth #535

wants to merge 5 commits into from

Conversation

SozinM
Copy link
Collaborator

@SozinM SozinM commented Apr 2, 2025

📝 Summary

Updated deps
Fix conflicts
Get impl

Superseeds #532

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@SozinM SozinM force-pushed the msozin/op-rbuilder/reth-interop-usage branch 3 times, most recently from 10067d6 to c233f4a Compare April 7, 2025 14:01
@cody-wang-cb
Copy link
Contributor

cody-wang-cb commented Apr 8, 2025 •
edited
Loading

Hey @SozinM curious if there's plan to merge this soon? I think Optimism Ishumus hardfork needs reth >= 1.3.5 https://github.com/paradigmxyz/reth/releases/tag/v1.3.5, and we run op-rbuilder on our devnet which activates in 2 days

@SozinM
Copy link
Collaborator Author

SozinM commented Apr 9, 2025

Hi @cody-wang-cb
Image from this PR is already built: ghcr.io/flashbots/op-rbuilder:0.1.1-interop
This branch will need review to check that rbuilder works fine on reth 1.3.7

@cody-wang-cb
Copy link
Contributor

@SozinM thanks!
Also wondering if we can just bump it to 1.3.8 since there was an reth.ipc issue in 1.3.7. https://github.com/paradigmxyz/reth/releases/tag/v1.3.8
Should be minimal changes required

@SozinM
Copy link
Collaborator Author

SozinM commented Apr 9, 2025

Will do! Thanks for notifying!

SozinM added 5 commits April 9, 2025 19:30
@SozinM
rbuidler works + changes builder tx gas calculation
0b1adf4 
half broken, but vanilla builder works

update deps

Port isthmus fix for block building

Get reth implementation
@SozinM
Fix rollup-boost
9057307
@SozinM
revert changes to rbuilder
b5114c5
@SozinM
add EMPTY_REQUESTS_HASH for to flashblocks
59b4005
@SozinM
Bump to 1.3.8
7f05d34 
Change ethereum-consensus back to ralexstokes
@SozinM SozinM force-pushed the msozin/op-rbuilder/reth-interop-usage branch from cb587c6 to 7f05d34 Compare April 9, 2025 12:31
@SozinM
Copy link
Collaborator Author

SozinM commented Apr 9, 2025

@cody-wang-cb new image was released with reth v1.3.8
ghcr.io/flashbots/op-rbuilder:0.1.2-interop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ZanCorDX ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SozinM @cody-wang-cb