Skip to content

Add make command for op-rbuilder image and switch to nightly fmt #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add make command for op-rbuilder image and switch to nightly fmt #542

wants to merge 4 commits into from

Conversation

SozinM
Copy link
Collaborator

@SozinM SozinM commented Apr 7, 2025

Add +nightly for cargo fmt, clippy and fix
Run make fmt

📝 Summary

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 06:16
Copilot
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Makefile: Language not supported

@SozinM SozinM force-pushed the msozin/op-rbuilder/op-release-makefile branch from 06fe4d7 to 2e46d27 Compare April 7, 2025 08:20
@SozinM SozinM requested a review from sukoneck as a code owner April 7, 2025 12:16
@ZanCorDX
Copy link
Contributor

ZanCorDX commented Apr 8, 2025

Please don't merge until we discuss the "nightly".

@SozinM SozinM force-pushed the msozin/op-rbuilder/op-release-makefile branch from 4771763 to 4464b1e Compare April 9, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ZanCorDX ZanCorDX ZanCorDX approved these changes

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@sukoneck sukoneck Awaiting requested review from sukoneck sukoneck is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SozinM @ZanCorDX