-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider userAgent missing #25
base: master
Are you sure you want to change the base?
Conversation
Looks like this will fix issue #28 👍 @flexdinesh would you consider merging? |
This project is so old I can't even run it in my local anymore. I might have to upgrade the build setup and get rid of most of them because we don't need 'em anymore in 2023. Once I upgrade I will release this change as part of a new major. In the meanwhile, are any of you able to run the branch in your local machine? I'm happy with the change but quite hesitant to merge with the optional chaining operator |
We are also hitting this with Node 21 as this is a downstream dep of Quicktype-core. I think the optional operator is probably fine since this is 1. a new version bump and 2. been supported since Node 14. That being said, you could also add an "engines": {
"node": ">=140.0"
}, |
Temporary until flexdinesh/browser-or-node#25 is merged/released.
Changes shipped in 3.0.0-pre.0 |
Self explanatory!
It would be useful for not breaking frameworks like react-native, that don't have userAgent in their navigator