Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reenable setuptools coverage build #260

Merged
merged 10 commits into from
Feb 8, 2025

Conversation

oscarbenjamin
Copy link
Collaborator

@oscarbenjamin
Copy link
Collaborator Author

So the situation seems to be that the coverage build with setuptools works apart from a Python 3.13 problem due to cython/cython#6658 which introduced the change somewhere in between cython 3.0.11 (latest release) and 3.1.0a1.

That same bug applies to the meson coverage build. Unfortunately the meson coverage build already requires cython/cython#6341 so 3.0.11 is not usable. Because of another Cython bug the first usable commit is cython/cython@fdbca99 which also precedes cython/cython#6658.

However even with that Cython commit there is still another Python 3.13 related bug. The problem that I fixed in cython/cython#6341 seems to have now reemerged but as a Python 3.13 only problem where the tracer outputs basenames for some files. There must be some 3.13-only paths in Cython that have reintroduced the basename bug.

All in all then the situation is that:

  • the meson coverage build works only for Python < 3.13 and can work with 3.1.0a1 as the earliest working release.
  • The setuptools coverage build works for all Python versions with Cython 3.0.11 but does not work for Python 3.13 as of Cython 3.1.0a1.

@oscarbenjamin oscarbenjamin merged commit f44a589 into flintlib:main Feb 8, 2025
39 checks passed
@oscarbenjamin oscarbenjamin deleted the pr_coverage_again branch February 8, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant