Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed check for required properties on change #13

Merged
merged 6 commits into from
Mar 12, 2014

Conversation

paulpflug
Copy link
Contributor

requirement of instanceof Diff is way to strong

@flitbit
Copy link
Collaborator

flitbit commented Mar 12, 2014

Makes sense to the scripting side of my brain, offends the type safe side. I'll go with it since it allows change records that are externally generated to be applied to an the object -- adds utility.

flitbit pushed a commit that referenced this pull request Mar 12, 2014
Changed check for required properties on `change`
@flitbit flitbit merged commit 55eeee3 into flitbit:master Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants